assign tests y and x should be the same for nullptr case

SteveBronder · SteveBronder · commit a49035c79a4a · 2023-11-29T16:06:29.000-05:00
diff --git a/test/unit/math/rev/core/var_test.cpp b/test/unit/math/rev/core/var_test.cpp
@@ -935,7 +935,7 @@ TEST_F(AgradRev, assign_nan) {
   EXPECT_MATRIX_EQ(y_ans_adj, y.adj());
 }
 
-TEST_F(AgradRev, assign_nullptr_vari) {
+TEST_F(AgradRev, assign_nullptr_var) {
   using stan::math::var_value;
   using var_vector = var_value<Eigen::Matrix<double, -1, 1>>;
   using stan::math::var;
@@ -954,6 +954,5 @@ TEST_F(AgradRev, assign_nullptr_vari) {
     x_ans_adj(i) = -(i + 0.1);
   }
   EXPECT_MATRIX_EQ(x.adj(), x_ans_adj);
-  Eigen::VectorXd y_ans_adj = Eigen::VectorXd::Zero(10);
-  EXPECT_MATRIX_EQ(y_ans_adj, y.adj());
+  EXPECT_MATRIX_EQ(x_ans_adj, y.adj());
 }

Original file line number	Diff line number	Diff line change
`@@ -935,7 +935,7 @@ TEST_F(AgradRev, assign_nan) {`
`935`	`935`	`EXPECT_MATRIX_EQ(y_ans_adj, y.adj());`
`936`	`936`	`}`
`937`	`937`
`938`		`-TEST_F(AgradRev, assign_nullptr_vari) {`
	`938`	`+TEST_F(AgradRev, assign_nullptr_var) {`
`939`	`939`	`using stan::math::var_value;`
`940`	`940`	`using var_vector = var_value<Eigen::Matrix<double, -1, 1>>;`
`941`	`941`	`using stan::math::var;`
`@@ -954,6 +954,5 @@ TEST_F(AgradRev, assign_nullptr_vari) {`
`954`	`954`	`x_ans_adj(i) = -(i + 0.1);`
`955`	`955`	`}`
`956`	`956`	`EXPECT_MATRIX_EQ(x.adj(), x_ans_adj);`
`957`		`- Eigen::VectorXd y_ans_adj = Eigen::VectorXd::Zero(10);`
`958`		`- EXPECT_MATRIX_EQ(y_ans_adj, y.adj());`
	`957`	`+ EXPECT_MATRIX_EQ(x_ans_adj, y.adj());`
`959`	`958`	`}`