remove extra setZero()

SteveBronder · SteveBronder · commit 7a609a664cac · 2023-11-29T15:46:19.000-05:00
diff --git a/stan/math/rev/core/var.hpp b/stan/math/rev/core/var.hpp
@@ -390,8 +390,6 @@ class var_value<T, internal::require_matrix_var_value<T>> {
     reverse_pass_callback(
         [this_vi = this->vi_, other_vi = other.vi_]() mutable {
           other_vi->adj_ += this_vi->adj_;
-          // Reset the adjoint for `this` to replicate SoA before assignment
-          this_vi->adj_.setZero();
         });
   }
 

Original file line number	Diff line number	Diff line change
`@@ -390,8 +390,6 @@ class var_value<T, internal::require_matrix_var_value<T>> {`
`390`	`390`	`reverse_pass_callback(`
`391`	`391`	`[this_vi = this->vi_, other_vi = other.vi_]() mutable {`
`392`	`392`	`other_vi->adj_ += this_vi->adj_;`
`393`		- // Reset the adjoint for `this` to replicate SoA before assignment
`394`		`- this_vi->adj_.setZero();`
`395`	`393`	`});`
`396`	`394`	`}`
`397`	`395`