Skip to content

Remove -A clippy::uninlined-format-args from clippy-stacks and fix all warnings #6278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 14, 2025

Conversation

jferrant
Copy link
Contributor

No description provided.

jferrant added 7 commits July 10, 2025 10:46
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant requested review from hstove, obycode and fdefelici July 10, 2025 18:34
@jferrant jferrant requested review from a team as code owners July 10, 2025 18:34
@jferrant jferrant self-assigned this Jul 10, 2025
@jferrant jferrant moved this to Status: In Review in Stacks Core Eng Jul 10, 2025
jferrant added 2 commits July 11, 2025 09:01
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant requested a review from obycode July 11, 2025 16:08
fdefelici
fdefelici previously approved these changes Jul 11, 2025
Copy link
Contributor

@fdefelici fdefelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt!

obycode
obycode previously approved these changes Jul 11, 2025
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Jul 11, 2025
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 60.39823% with 179 lines in your changes missing coverage. Please review.

Project coverage is 82.06%. Comparing base (7d63003) to head (e26b9ea).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
clarity/src/vm/ast/errors.rs 37.50% 20 Missing ⚠️
clarity/src/vm/analysis/errors.rs 69.81% 16 Missing ⚠️
clarity/src/vm/ast/parser/v2/mod.rs 0.00% 16 Missing ⚠️
clarity/src/vm/ast/parser/v2/lexer/error.rs 0.00% 14 Missing ⚠️
clarity/src/vm/types/mod.rs 67.50% 13 Missing ⚠️
clarity/src/vm/events.rs 46.66% 8 Missing ⚠️
clarity/src/vm/tests/defines.rs 11.11% 8 Missing ⚠️
stacks-common/src/util/pipe.rs 46.66% 8 Missing ⚠️
clarity/src/vm/contexts.rs 41.66% 7 Missing ⚠️
stacks-signer/src/cli.rs 12.50% 7 Missing ⚠️
... and 27 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6278      +/-   ##
===========================================
+ Coverage    82.00%   82.06%   +0.06%     
===========================================
  Files          545      545              
  Lines       347218   347176      -42     
  Branches       323      323              
===========================================
+ Hits        284727   284903     +176     
+ Misses       62483    62265     -218     
  Partials         8        8              
Files with missing lines Coverage Δ
clarity/src/vm/analysis/read_only_checker/tests.rs 100.00% <100.00%> (ø)
clarity/src/vm/analysis/trait_checker/tests.rs 85.42% <ø> (ø)
...src/vm/analysis/type_checker/v2_05/tests/assets.rs 99.24% <100.00%> (ø)
.../vm/analysis/type_checker/v2_05/tests/contracts.rs 99.58% <100.00%> (ø)
...ty/src/vm/analysis/type_checker/v2_05/tests/mod.rs 99.89% <100.00%> (-0.01%) ⬇️
.../src/vm/analysis/type_checker/v2_1/tests/assets.rs 100.00% <100.00%> (ø)
...c/vm/analysis/type_checker/v2_1/tests/contracts.rs 95.69% <100.00%> (ø)
...ity/src/vm/analysis/type_checker/v2_1/tests/mod.rs 99.83% <100.00%> (-0.01%) ⬇️
clarity/src/vm/ast/parser/v2/lexer/mod.rs 94.76% <100.00%> (ø)
clarity/src/vm/database/clarity_store.rs 40.00% <100.00%> (ø)
... and 54 more

... and 49 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d63003...e26b9ea. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jferrant jferrant dismissed stale reviews from obycode and fdefelici via e26b9ea July 11, 2025 20:08
@jferrant jferrant requested review from obycode and fdefelici July 11, 2025 20:08
@obycode obycode added this pull request to the merge queue Jul 14, 2025
Merged via the queue into stacks-network:develop with commit fe32c74 Jul 14, 2025
239 of 240 checks passed
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants