Skip to content

[clarity-wasm] fix function context rollback #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

csgui
Copy link

@csgui csgui commented Jul 10, 2025

This change needs to be reverted, as it adds an additional call to global_context.rollback(), which in turn disrupts the function call context.

This change needs to be reverted, as it adds an additional call to global_context.rollback(),
 which in turn disrupts the function call context.
@csgui csgui requested a review from a team as a code owner July 10, 2025 18:19
@csgui csgui marked this pull request as draft July 10, 2025 18:19
@csgui csgui self-assigned this Jul 10, 2025
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 21.40%. Comparing base (396a0da) to head (b299de5).
Report is 4 commits behind head on feat/clarity-wasm-develop.

Files with missing lines Patch % Lines
clarity/src/vm/clarity_wasm.rs 60.00% 2 Missing ⚠️

❌ Your project status has failed because the head coverage (21.40%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feat/clarity-wasm-develop    #6277      +/-   ##
=============================================================
+ Coverage                      21.39%   21.40%   +0.01%     
=============================================================
  Files                            526      526              
  Lines                         339890   339879      -11     
  Branches                         323      323              
=============================================================
+ Hits                           72728    72763      +35     
+ Misses                        267154   267108      -46     
  Partials                           8        8              
Files with missing lines Coverage Δ
clarity/src/vm/clarity_wasm.rs 33.51% <60.00%> (+0.05%) ⬆️

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86af212...b299de5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@csgui csgui marked this pull request as ready for review July 10, 2025 19:22
BowTiedWoo
BowTiedWoo previously approved these changes Jul 10, 2025
Acaccia
Acaccia previously approved these changes Jul 11, 2025
@csgui csgui dismissed stale reviews from Acaccia and BowTiedWoo via b299de5 July 11, 2025 09:58
@csgui csgui requested review from Acaccia and BowTiedWoo July 11, 2025 09:59
@csgui csgui merged commit 84974e6 into stacks-network:feat/clarity-wasm-develop Jul 11, 2025
66 of 201 checks passed
@csgui csgui deleted the fix/function-context-rollback branch July 11, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants