-
Notifications
You must be signed in to change notification settings - Fork 697
fix: nix
build and CI
#6274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: nix
build and CI
#6274
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6274 +/- ##
===========================================
+ Coverage 81.96% 82.04% +0.08%
===========================================
Files 543 543
Lines 345677 345677
Branches 323 323
===========================================
+ Hits 283332 283626 +294
+ Misses 62337 62043 -294
Partials 8 8 see 50 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
The changes seem fine, but the question to ask is - should we be running this job on every PR/commit? it's an expensive job to run indicated by the timing (22m of runtime), and that was part of the reason we removed the docker image build on each PR/commit (deferring to run it manually when needed). leaving it as-is isn't a bad thing either - i just see it as a tradeoff: we may find that PR's take longer to merge, and will have to possibly ignore failures when this job takes longer than usual (the other reason we stopped running the docker image build in PR's). |
Fair points! I have just re-run the CI after merging |
Unfortunately it's still in the 20 minutes range. I am not sure if we want to explore it, (I could try it out myself when I merge my current work), but there could be a chance to maybe improve this by a lot with https://github.com/cachix/cachix-action . They offer a 5GB free cache for open source projects that I believe should be enough for this |
It seems to be spending time unpacking from the cache, I think, so I am not sure we would get an improvement (but it is worth trying). Is 20m really a problem? The other CI tests take 1h (at least on this PR). If we believe it's a problem, I'll just replicate the Docker build CI workflow here. |
Description
This PR fixes nix builds, broken since 826c7cc, by adding the corresponding path to the fileset.
In addition, it adds a CI check for Nix builds.