Skip to content

chore: upgrade time crate #6271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2025

Conversation

hugocaillard
Copy link
Contributor

@hugocaillard hugocaillard commented Jul 9, 2025

Description

  • Upgrade time crate to 0.3
  • Remove time crate from clarity and stacks-common (unused)
  • It removes 17 (old) dependencies from Cargo.lock.

Breaking change: this PR, in its current form, updates the header date format to actually follow the rfc 7231 format.
If this change isn't wanted, I can also format the data back to the old version (and still keep the dependency upgrade)

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@hugocaillard hugocaillard marked this pull request as ready for review July 9, 2025 20:20
@hugocaillard hugocaillard requested review from a team as code owners July 9, 2025 20:20
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.78%. Comparing base (c86013a) to head (5e10cfa).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/net/http/tests.rs 14.28% 6 Missing ⚠️

❌ Your project status has failed because the head coverage (77.78%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6271       +/-   ##
============================================
+ Coverage    56.46%   77.78%   +21.31%     
============================================
  Files          546      546               
  Lines       347228   347236        +8     
  Branches       323      323               
============================================
+ Hits        196059   270081    +74022     
+ Misses      151161    77147    -74014     
  Partials         8        8               
Files with missing lines Coverage Δ
stacks-common/src/util/mod.rs 88.88% <ø> (+1.38%) ⬆️
stackslib/src/net/http/response.rs 82.25% <100.00%> (+11.59%) ⬆️
stackslib/src/net/http/tests.rs 80.46% <14.28%> (+51.11%) ⬆️

... and 387 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c86013a...5e10cfa. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kantai
kantai previously approved these changes Jul 10, 2025
@hugocaillard hugocaillard requested a review from obycode July 10, 2025 15:10
obycode
obycode previously approved these changes Jul 10, 2025
@hugocaillard hugocaillard dismissed stale reviews from obycode and kantai via 5e10cfa July 10, 2025 16:26
@hugocaillard hugocaillard requested review from kantai and obycode July 10, 2025 16:27
@obycode obycode added this pull request to the merge queue Jul 10, 2025
Merged via the queue into stacks-network:develop with commit ddcff25 Jul 10, 2025
239 of 240 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants