-
Notifications
You must be signed in to change notification settings - Fork 697
chore: build clarity for wasm32-unknown-unknown #6268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
chore: build clarity for wasm32-unknown-unknown #6268
Conversation
I just saw #6239, which is super promising for clarinet. The two PRs enable similar things (compile to wasm), but also, this specific one (6268) add some changes needed specifically for clarinet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
7ece404
to
94c13c9
Compare
94c13c9
to
101a3bb
Compare
@obycode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks @Jiloc! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6268 +/- ##
============================================
+ Coverage 62.18% 82.07% +19.89%
============================================
Files 546 546
Lines 347228 347238 +10
Branches 323 323
============================================
+ Hits 215912 284991 +69079
+ Misses 131308 62239 -69069
Partials 8 8
... and 379 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Description
Fix: #5891
With the PR, the clarity-vm can be compiled to wasm32-unknown-unknown, as it is being using the clarinet JS SDK.
It mostly hide a few things behind compilation flags.
This PR also includes a few changes that are need for clarinet. Mostly by making public certain functions.
WIth this PR, this command passes:
Once this is merged, this check should be added to the CI.
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml