Skip to content

refactor: improve burnchain missing headers error handling #6265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hugocaillard
Copy link
Contributor

Minor change.
As I'm about to close #4234 (uneeded), I though this change might be good.

cc @obycode

@hugocaillard hugocaillard requested review from a team as code owners July 8, 2025 13:34
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks safe to me. The existing uses will still end up panicking higher up the stack.

@hugocaillard hugocaillard force-pushed the refactor/burnchain-missing-block-header-error-handling branch from c3bfe01 to 3a50a9c Compare July 9, 2025 08:39
@hugocaillard
Copy link
Contributor Author

I can not add reviewers to the PR;
@kantai Can you have a look at this one?

@obycode obycode requested a review from kantai July 10, 2025 16:17
@obycode obycode added this pull request to the merge queue Jul 10, 2025
Merged via the queue into stacks-network:develop with commit b30a09e Jul 10, 2025
236 of 240 checks passed
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.97%. Comparing base (bc58a1e) to head (3a50a9c).
Report is 80 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/burnchains/bitcoin/indexer.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6265       +/-   ##
============================================
+ Coverage    45.49%   81.97%   +36.48%     
============================================
  Files          536      543        +7     
  Lines       343845   345655     +1810     
  Branches         0      323      +323     
============================================
+ Hits        156439   283367   +126928     
+ Misses      187406    62280   -125126     
- Partials         0        8        +8     
Files with missing lines Coverage Δ
stackslib/src/burnchains/bitcoin/indexer.rs 34.65% <50.00%> (+8.79%) ⬆️

... and 442 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc58a1e...3a50a9c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants