feat: add cargo hack check on ci

[Jiloc]

Description

This PR builds on top of #6239, and will be rebased once the other PR will be merged.

The only three changes are:

• .github/workflows/cargo-hack-check.yml
• .github/workflows/ci.yml
• .github/workflows/constants-check.yml

This PR introduces a new, reusable action workflow (cargo-hack-check.yml) to verify that all feature flag in our workspace compile successfully.

The goal is not to accidentally break our support for wasm in future PRs, and prevent accedentally break feature flags like it recently happened in #6228

It is structured into three main stages:

• setup: A quick preliminary job that reads the Rust toolchain version from the rust-toolchain file. This value is passed to subsequent jobs to ensure they all use the correct and consistent Rust version.
• Parallel Checks: Two jobs run in parallel:
  • native-targets: This job handles builds for linux and windows (x86_64-unknown-linux-gnu and x86_64-pc-windows-gnu). It runs cargo hack check across all crates and for each feature individually. It would be possible to also do it for all permutations, but it would take too long for a CI work, I suppose.
  • wasm-targets: This job specifically handles our WASM builds. It uses a matrix strategy to run two separate checks for our distinct WASM use cases:
    • One for the wasm-web feature set.
    • One for the wasm-deterministic feature set.
      This job has fail-fast: false so that a failure in one WASM check doesn't prevent the other from running.

Also: .github/workflows/core-build-tests.yml was renamed to ‎.github/workflows/constants-check.yml. This workflow contained a subset of the cargo checks that we are now performing via cargo hack. After removing those check, I thought of renaming it.

Applicable issues

• fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[Jiloc]

Overall this looks fine! I’ve added a few minor remaks.

One clarification: the PR description mentions a check-results stage as a final summary job, but I don’t see it defined in the cargo-hack-check.yml workflow. Was this step intended but not included, or is the description out of date?

The initial implementation contained the final check, but I removed it in a later commit 66cf8ba, as I realized it was redundant. But I forgot to remove it from the description 👍

[codecov]

Codecov Report

Attention: Patch coverage is 85.12793% with 279 lines in your changes missing coverage. Please review.

Project coverage is 81.97%. Comparing base (381ee9b) to head (75c4155).
Report is 16 commits behind head on develop.

Files with missing lines	Patch %	Lines
clarity/src/vm/costs/tracker.rs	82.90%	159 Missing ⚠️
clarity/src/vm/ast/ast_builder.rs	82.43%	75 Missing ⚠️
clarity/src/vm/core.rs	90.41%	37 Missing ⚠️
clarity/src/vm/analysis/engine.rs	94.94%	5 Missing ⚠️
stacks-common/src/util/secp256k1/native.rs	0.00%	2 Missing ⚠️
clarity/src/vm/representations.rs	91.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6262      +/-   ##
===========================================
- Coverage    82.10%   81.97%   -0.13%     
===========================================
  Files          546      546              
  Lines       347235   347218      -17     
  Branches       323      323              
===========================================
- Hits        285088   284626     -462     
- Misses       62139    62584     +445     
  Partials         8        8              

Files with missing lines	Coverage Δ
clarity/src/libclarity.rs	55.55% <ø> (ø)
...larity/src/vm/analysis/arithmetic_checker/tests.rs	98.51% <100.00%> (ø)
...c/vm/analysis/type_checker/v2_1/tests/contracts.rs	95.69% <100.00%> (ø)
clarity/src/vm/ast/parser/v2/lexer/mod.rs	94.76% <100.00%> (ø)
clarity/src/vm/ast/parser/v2/parser_impl.rs	55.46% <ø> (ø)
clarity/src/vm/callables.rs	96.50% <ø> (+0.12%)	⬆️
clarity/src/vm/contexts.rs	91.76% <ø> (ø)
clarity/src/vm/costs/mod.rs	42.85% <ø> (-39.86%)	⬇️
clarity/src/vm/database/sqlite.rs	81.97% <ø> (ø)
clarity/src/vm/docs/mod.rs	90.09% <ø> (ø)
... and 19 more

... and 50 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 381ee9b...75c4155. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[wileyj]

lgtm - waiting on #6239 to merge so this PR is only for the workflow changes