-
Notifications
You must be signed in to change notification settings - Fork 698
Feat/sip 031 epoch32 #6258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/3.2.0.0.0-rc1
Are you sure you want to change the base?
Feat/sip 031 epoch32 #6258
Conversation
Co-authored-by: Brice <brice@obycode.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changeset looks good to me, but I think we need to either:
- Stage all of the 3.2 changes in a new branch and then merge it all at once to develop.
- Change the epoch definitions in this PR so that Epoch 3.2 won't activate without a followup PR that sets the block heights, latest epoch, etc.
I definitely prefer 2, seems way cleaner (i am preparying a very tiny pull request just for the activation) |
Codecov ReportAttention: Patch coverage is
❌ Your project check has failed because the head coverage (71.72%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6258 +/- ##
===========================================
- Coverage 81.15% 71.72% -9.43%
===========================================
Files 546 546
Lines 347235 347489 +254
Branches 323 323
===========================================
- Hits 281797 249240 -32557
- Misses 65430 98241 +32811
Partials 8 8
... and 256 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Description
This is the first step for SIP-031 implementation: Epoch 3.2 transition.
The activation functions is currently a stub (it will be implemented in another patch)
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml