Skip to content

Feat/sip 031 epoch32 #6258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: release/3.2.0.0.0-rc1
Choose a base branch
from

Conversation

rdeioris
Copy link
Contributor

@rdeioris rdeioris commented Jul 7, 2025

Description

This is the first step for SIP-031 implementation: Epoch 3.2 transition.

The activation functions is currently a stub (it will be implemented in another patch)

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@rdeioris rdeioris marked this pull request as ready for review July 7, 2025 12:15
@rdeioris rdeioris requested review from a team as code owners July 7, 2025 12:15
@aldur aldur requested review from obycode and kantai July 7, 2025 15:09
@aldur aldur moved this to Status: In Review in Stacks Core Eng Jul 7, 2025
@aldur aldur added this to the 3.1.0.0.14 milestone Jul 7, 2025
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Jul 7, 2025
@rdeioris rdeioris requested a review from obycode July 8, 2025 05:25
Copy link
Contributor

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changeset looks good to me, but I think we need to either:

  1. Stage all of the 3.2 changes in a new branch and then merge it all at once to develop.
  2. Change the epoch definitions in this PR so that Epoch 3.2 won't activate without a followup PR that sets the block heights, latest epoch, etc.

@rdeioris
Copy link
Contributor Author

rdeioris commented Jul 11, 2025

This changeset looks good to me, but I think we need to either:

  1. Stage all of the 3.2 changes in a new branch and then merge it all at once to develop.
  2. Change the epoch definitions in this PR so that Epoch 3.2 won't activate without a followup PR that sets the block heights, latest epoch, etc.

I definitely prefer 2, seems way cleaner (i am preparying a very tiny pull request just for the activation)

@rdeioris rdeioris requested a review from kantai July 11, 2025 14:07
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 13.66667% with 259 lines in your changes missing coverage. Please review.

Project coverage is 71.72%. Comparing base (381ee9b) to head (2cb5750).

Files with missing lines Patch % Lines
stackslib/src/core/mod.rs 0.00% 138 Missing ⚠️
stacks-node/src/tests/nakamoto_integrations.rs 6.18% 91 Missing ⚠️
stackslib/src/clarity_vm/clarity.rs 0.00% 17 Missing ⚠️
stackslib/src/chainstate/stacks/db/blocks.rs 57.14% 3 Missing ⚠️
stackslib/src/config/mod.rs 0.00% 3 Missing ⚠️
clarity/src/vm/version.rs 0.00% 1 Missing ⚠️
stacks-common/src/types/mod.rs 88.88% 1 Missing ⚠️
stackslib/src/chainstate/burn/db/sortdb.rs 0.00% 1 Missing ⚠️
.../chainstate/burn/operations/leader_block_commit.rs 0.00% 1 Missing ⚠️
stackslib/src/chainstate/stacks/db/mod.rs 0.00% 1 Missing ⚠️
... and 2 more

❌ Your project check has failed because the head coverage (71.72%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (381ee9b) and HEAD (2cb5750). Click for more details.

HEAD has 50 uploads less than BASE
Flag BASE (381ee9b) HEAD (2cb5750)
127 77
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6258      +/-   ##
===========================================
- Coverage    81.15%   71.72%   -9.43%     
===========================================
  Files          546      546              
  Lines       347235   347489     +254     
  Branches       323      323              
===========================================
- Hits        281797   249240   -32557     
- Misses       65430    98241   +32811     
  Partials         8        8              
Files with missing lines Coverage Δ
clarity/src/vm/analysis/mod.rs 94.94% <ø> (ø)
clarity/src/vm/analysis/type_checker/mod.rs 93.75% <100.00%> (ø)
clarity/src/vm/costs/mod.rs 76.73% <100.00%> (-5.98%) ⬇️
clarity/src/vm/functions/mod.rs 97.96% <100.00%> (+<0.01%) ⬆️
clarity/src/vm/test_util/mod.rs 41.09% <100.00%> (ø)
clarity/src/vm/tests/mod.rs 62.50% <ø> (-7.82%) ⬇️
clarity/src/vm/types/signatures.rs 90.59% <100.00%> (-0.30%) ⬇️
stacks-common/src/libcommon.rs 75.00% <ø> (ø)
stacks-common/src/types/tests.rs 100.00% <100.00%> (ø)
stackslib/src/chainstate/coordinator/mod.rs 76.51% <ø> (-2.18%) ⬇️
... and 13 more

... and 256 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 381ee9b...2cb5750. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aldur aldur changed the base branch from develop to release/3.2.0.0.0-rc1 July 11, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Status: 💻 In Progress
Development

Successfully merging this pull request may close these issues.

4 participants