-
Notifications
You must be signed in to change notification settings - Fork 697
refactor: move stacks-node
crate to workspace root
#6254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move stacks-node
crate to workspace root
#6254
Conversation
08e20ba
to
fb6e5f6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6254 +/- ##
===========================================
- Coverage 81.95% 80.65% -1.30%
===========================================
Files 546 546
Lines 347235 347235
Branches 323 323
===========================================
- Hits 284576 280065 -4511
- Misses 62651 67162 +4511
Partials 8 8
... and 47 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job! I believe we are almost there, I also grepped for all testnet in the code, I believe you missed only
"testnet") - https://github.com/stacks-network/stacks-core/blob/a5587d13c51829f49a7645d9484469e5ca891e29/docs/mutation-testing.md a few references to the "testnet" folder
that needs to be changed to "stacks-node" now. I'll give a second look at the results
Maybe the mutation testing script and related documentation can be removed in a dedicated PR. |
Correct - i thought i had commented on these files in another PR, but i can't find it so i'll assume it didn't happen. I would say we can remove those files in this PR, or ack that the changes missed are OK since they will be removed later. |
Ok. I opened a specific issue for this #6275 to keep this PR scoped |
fb6e5f6
to
26c61f2
Compare
26c61f2
to
d85ae0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
381ee9b
🎉 |
Description
This patch moves the
stacks-node
crate fromtestnet/stacks-node
to the root of the workspace, aligning it with the structure of other crates.Additionally, this PR includes a small cleanup of the
.gitignore
file, other than the one required fortestnet/
refactor.NOTE:
stacks-networks/actions
need to be updated (about nextest cache preparation). Here the related patch PR #78 with a "fallback compatibility mode" that has been mergedApplicable issues
stacks-node
crate to workspace root #6252Additional info (benefits, drawbacks, caveats)
After the move, references to the
testnet/
path remain in the following locations:CONTRIBUTING.md
migration-verification
tool> CONTRIBUTING.md
In the coding guidelines section, the following example links still reference the previous path:
Proposal: Leave these links as-is for now, since they serve as point-in-time examples, OR we can update them in a follow-up PR after this one is merged, once we have a new commit to reference
> MIGRATION VERIFICATION TOOL
This tool was used during the transition from
Stacks 1.0
toStacks 2.0
Proposal: If the tool is no longer needed, we should consider removing it.
UPDATE: As shared during the nakasync we opted for:
CONTRIBUTING.md
by now.MIGRATION VERIFICATION
tool in a dedicated PR (opened issue: chore: removemigration-verification
tool #6264)Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml