-
Notifications
You must be signed in to change notification settings - Fork 697
refactor: clean op signer #6249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
refactor: clean op signer #6249
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6249 +/- ##
===========================================
- Coverage 82.10% 82.04% -0.06%
===========================================
Files 546 546
Lines 347235 347268 +33
Branches 323 323
===========================================
- Hits 285088 284933 -155
- Misses 62139 62327 +188
Partials 8 8
... and 40 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
bdff47b
to
ea2c239
Compare
Description
BurnchainOpSigner
is consistently configured to be disposed of explicitly via theBurnchainOpSigner::dispose()
method.Therefore, the logic for automatically disposing of it during signing operations can be safely removed.
Also add test coverage for
BurnchainOpSigner
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml