-
Notifications
You must be signed in to change notification settings - Fork 697
refactor: regtest controller cleanup #6243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
refactor: regtest controller cleanup #6243
Conversation
4b7b52c
to
69bf666
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a comment about the modularization of the tests. I like it and I believe we can keep it. But the extra indentetion made the diff difficult to review :( ! If we are going to refactor other tests into their own modules in the future, I'd suggest to split the indentation change to its own commit. It will be easier to review the single commits intead of the final diff!
Codecov ReportAttention: Patch coverage is
❌ Your project check has failed because the head coverage (70.60%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6243 +/- ##
===========================================
- Coverage 71.20% 70.60% -0.60%
===========================================
Files 546 546
Lines 347235 347511 +276
Branches 323 323
===========================================
- Hits 247236 245358 -1878
- Misses 99991 102145 +2154
Partials 8 8
... and 372 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Description
This PR does some housekeeping around the
bitcoin_regetest_controller
module, removing some unused code (found while working on #6219):attempt
args inBitcoinRegtestController::submit_operation(..)
(and descendant method in tha call stacks)allow_rbf
member inBitcoinRegtestController
that is always initialized totrue
(simplify some internal branch logic)Applicable issues
BitcoinRegtestController
#6253Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml