Second round of snapshottable signer tests

[rdeioris]

Description

This patch adds snapshot support for a set of signer's unit tests

Applicable issues

• fixes Integration test from snapshot #5800

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[fdefelici]

Is the snapshot activation code missing here?

 if signer_test.bootstrap_snapshot() {
        signer_test.shutdown_and_snapshot();
        return;
 }

Just a heads-up: this might conflict with PR #6212, where @hank reviewed all the tx_replay_* test methods (applying also snapshotting)

[hank]

Just a heads-up: this might conflict with PR #6212, where @hank reviewed all the tx_replay_* test methods (applying also snapshotting)

I did? I don't remember doing that...

[fdefelici]

Just a heads-up: this might conflict with PR #6212, where @hank reviewed all the tx_replay_* test methods (applying also snapshotting)

I did? I don't remember doing that...

I would say yes :) Here an example taken from your PR on test tx_replay_reject_invalid_proposals_during_replay.

[hank]

That appears to be from someone called @hstove. I'm @hank.

[hstove]

Yes, as @fdefelici pointed out, these need the "snapshot activation" code. For these to work, you'll also need to add activated_vrf_path, although I added that in to the default config in #6212 , which I would recommend doing here too.

[fdefelici]

That appears to be from someone called @hstove. I'm @hank.

ops! pardon!