-
Notifications
You must be signed in to change notification settings - Fork 698
chore: update openapi specs #6201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
would it be possible to also address this issue in this PR? |
tagging @cylewitruk since #4551 was his idea |
I'll open a separate PR for that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
pending resolution of the the openapi validation, this seems fine |
@wileyj note that in the latests changes I also moved the validation workflow to |
hmm, i see the reasoning but i think it's better to keep under stacks-core-tests. otherwise, without some extra conditionals checking that the stacks-core-tests job was successful, this step will run every time - even if tests or other steps/jobs are failing. it's not a bad thing necesarily (just adds noise), i just think it's better suited as part of the stacks-core-tests workflow. i'm less concerned that the create-test-cache workflow is gating this - if that fails, openapi validation shouldn't even run. Otherwise, i think the changes still look good - just have to reach consensus on where to run it (along with the composite workflow merge) |
This reverts commit 81ca206.
I moved it back in e858b09 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6201 +/- ##
============================================
+ Coverage 66.66% 82.05% +15.38%
============================================
Files 543 546 +3
Lines 345656 347235 +1579
Branches 323 323
============================================
+ Hits 230418 284910 +54492
+ Misses 115230 62317 -52913
Partials 8 8
... and 432 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the composite merged and working, i think this one is also ready to go
Description
This PR significantly updates and expands the openapi.yaml specification for the Stacks node RPC API. It adds definitions for numerous previously undocumented V2 and V3 endpoints, refactors common parameters into reusable components for consistency, and enhances existing endpoint definitions with more accurate details, schemas, and examples.
Key changes include:
redocly.yaml
configuration has been added, and the entire specification now passes the redocly lint check.liststackerdbreplicas
endpoint has been fixed (stackedb -> stackerdb).stacks-core-tests.yml
toci.yml
. While I was testing the new workflow, I realized that the validation would only start after the[CI / Create Test Cache / Test Archive]
step, that takes more than 10 minutes and that we can move it at an earlier step.Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml