Skip to content

Feat/signer two phase commit #6082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

jferrant
Copy link
Contributor

@jferrant jferrant commented May 5, 2025

Closes #6099

@jferrant jferrant force-pushed the feat/signer-two-phase-commit branch 2 times, most recently from 3156089 to c7dc731 Compare May 5, 2025 22:29
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant force-pushed the feat/signer-two-phase-commit branch from c7dc731 to 05285b2 Compare May 6, 2025 00:48
jferrant added 9 commits May 6, 2025 10:44
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 79.13279% with 77 lines in your changes missing coverage. Please review.

Project coverage is 82.42%. Comparing base (1e60445) to head (3ae5af9).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
testnet/stacks-node/src/tests/signer/v0.rs 47.19% 47 Missing ⚠️
stacks-signer/src/v0/signer.rs 86.40% 17 Missing ⚠️
libsigner/src/v0/messages.rs 83.54% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6082      +/-   ##
===========================================
+ Coverage    77.31%   82.42%   +5.11%     
===========================================
  Files          541      541              
  Lines       344258   344557     +299     
  Branches       323      323              
===========================================
+ Hits        266166   284007   +17841     
+ Misses       78084    60542   -17542     
  Partials         8        8              
Files with missing lines Coverage Δ
stacks-signer/src/monitoring/mod.rs 91.66% <100.00%> (+0.26%) ⬆️
stacks-signer/src/monitoring/prometheus.rs 100.00% <ø> (ø)
stacks-signer/src/signerdb.rs 92.99% <100.00%> (+6.18%) ⬆️
stacks-signer/src/v0/tests.rs 89.00% <100.00%> (+1.94%) ⬆️
...tacks-node/src/nakamoto_node/stackerdb_listener.rs 84.25% <100.00%> (+0.04%) ⬆️
libsigner/src/v0/messages.rs 86.23% <83.54%> (+4.49%) ⬆️
stacks-signer/src/v0/signer.rs 83.98% <86.40%> (+2.05%) ⬆️
testnet/stacks-node/src/tests/signer/v0.rs 46.47% <47.19%> (+1.21%) ⬆️

... and 224 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e60445...3ae5af9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jferrant added 6 commits June 30, 2025 09:46
…o get signer address

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
…nt/stacks-core into feat/signer-two-phase-commit
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant marked this pull request as ready for review July 10, 2025 17:43
@jferrant jferrant requested review from a team as code owners July 10, 2025 17:43
@jferrant jferrant self-assigned this Jul 10, 2025
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant marked this pull request as draft July 10, 2025 21:06
jferrant added 3 commits July 10, 2025 14:43
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant