Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Core Url update #191

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Filmaluco
Copy link
Contributor

No description provided.

Copy link
Contributor

@friedger friedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase the PR. This contains the changes from the last pr as well.

What about the DID method? Do you want to adapt the new specification?

@@ -19,6 +17,8 @@ class DIDs {

if (didType == "btc-addr") {
return did.split(':')[2]
}else if (didType == "stx-addr") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a more generic version, and updated the validation since according to the documentation the following
did:stack:v0:15gxXgJyT5tM5A4Cbx99nwccynHYsBouzr-3, is correct and can existe a multiple of different transactions, names, and namespaces.

@Filmaluco Filmaluco requested a review from friedger September 9, 2021 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants