e2e: fix tests with latest vuln data #1999
Conversation
e2etests/vuln_test.go
Outdated
| // These three vulns should exist, but NVD set these to deferred. | ||
| // Commenting out until they are no longer deferred. |
There was a problem hiding this comment.
How will we know when they're no longer deferred?
There was a problem hiding this comment.
https://youtu.be/se17_0zbZds?si=SHZtYEjhrSZ8xkPU&t=10
I considered just deleting these (open to that), but I also wanted to keep track of them in case we want to remember them in the future
There was a problem hiding this comment.
😂
My initial thought was to file a Jira issue, but after thinking about it a bit, would these tests fail when the CVEs are no longer deferred? Since the expected results would be different. If that's the case, the comment already in the changes is sufficient.
There was a problem hiding this comment.
I found out unexpectedVulns exists, so I moved all these vulns to that section. That way, we'll be notified when they're found
|
/retest |
RTann
force-pushed
the
fix-tests-07242025
branch
from
ac113e2 to
c3dd15a
Compare
|
@RTann: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.