ROX-28568: Add required tasks sast-shell-check and sast-unicode-check to Konflux pipelines

[tommartensen]

Description

Adds two more required tasks to the Konflux pipelines.

Checklist

• Investigated and inspected CI test results
• Updated documentation accordingly

Automated testing

• Added unit tests
• Added integration tests
• Added regression tests

If any of these don't apply, please comment below.

Testing Performed

See description of stackrox/scanner#1881 for validation. Note that EC may display erroneous results for required task presences.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.52%. Comparing base (b3acca9) to head (836e99c).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2115   +/-   ##
=======================================
  Coverage   28.52%   28.52%           
=======================================
  Files          94       94           
  Lines        5757     5757           
  Branches     2547     2547           
=======================================
  Hits         1642     1642           
  Misses       3393     3393           
  Partials      722      722           

Flag	Coverage Δ
collector-unit-tests	28.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tommartensen]

/retest

[tommartensen]

/retest

[tommartensen]

/test collector-on-push

[sourcery-ai]

Hey @tommartensen - I've reviewed your changes - here's some feedback:

• Consider adding explicit runAfter fields for the new tasks to make the execution order clear rather than relying solely on implicit data dependencies.
• DRY up the repeated param definitions (image-digest, image-url, SOURCE_ARTIFACT, CACHI2_ARTIFACT) by using YAML anchors or promoting them to pipeline-level params.
• Ensure these tasks are included in any pipeline-required-tasks metadata or enforcement logic so they actually get flagged as required in the UI/CLI.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}