Skip to content

Add a default first menu item implementation. #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2025
Merged

Add a default first menu item implementation. #97

merged 3 commits into from
Jan 9, 2025

Conversation

furby-tm
Copy link
Contributor

@furby-tm furby-tm commented Jan 4, 2025 •
edited
Loading

  • Created a default first menu item implementation, which is better than a dummy because this presents a standard "About MyApp" and ability to quit the app, similar to the default first menu item that SwiftUI creates by default on macOS.

It looks like the following:
Screenshot 2025-01-04 at 2 31 44 PM

furby-tm and others added 3 commits January 4, 2025 14:20
@furby-tm
Add first menu item for appkit backend.
ea9a8b7 
Signed-off-by: furby™ <devs@wabi.foundation>
@furby-tm
fix package dependencies.
f90b3ea 
Signed-off-by: furby™ <devs@wabi.foundation>
@stackotter
Merge branch 'layout_system' into layout_system
1a71088
stackotter
stackotter approved these changes Jan 9, 2025
View reviewed changes
Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just trying out locally before merging

@stackotter stackotter merged commit d2dd03a into stackotter:layout_system Jan 9, 2025
1 check passed
@stackotter
Copy link
Owner

Thanks for PRing this! Great quality of life improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackotter stackotter stackotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@furby-tm @stackotter