Update view/scene builders to support up to 20 views/scenes (fixes #198) #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resulted in 7500 lines less code, 1mb smaller debug binaries and 0.5mb smaller release binaries
|
My latest commit reduced repetition in the generated code quite significantly (7500 lines less code) and resulted in 1mb smaller debug binaries and 0.5mb smaller release binaries. CounterExample binary size (AppKitBackend + Swift 6.0.3)Debug
Release
|
valeriyvan
reviewed
Jun 28, 2025
There was a problem hiding this comment.
I don't think changes in this file belong to this PR.
There was a problem hiding this comment.
I only made the change in this PR because it was required to get one of the size optimisations working. When I moved one of the repeated function bodies into
a helper method, I needed to make the helper MainActor and then started getting all sorts of concurrency warning about LayoutableChild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just updates SwiftCrossUI's view/scene builders to support up to 20 views/scenes by updating some constants in our gyb files.
I've tested build performance with and without these extra tuple views/scenes and builder methods, and build times don't seem to have been affected.
Unfortunately these changes do make CounterExample's binary 2mb larger in both debug mode and release mode (about 20% bigger for such a simple app). Perhaps I can gate this behind an 'SCUI_EXTENDED_BUILDERS` environment variable for now and then make it a trait once we bump to Swift 6.1?
Before I merge this, I'll also attempt to reduce the size of the generated files by moving repeated logic into generic helper methods, because this PR currently has 10,000 additions, which is a ridiculous amount of repetitive code.