Skip to content

Add wokrflow to test on ubuntu-22.04, rename swift-linux.yml -> ubuntu-24.04 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

valeriyvan
Copy link
Contributor

Addresses #153

@valeriyvan valeriyvan force-pushed the ubuntu-version branch 2 times, most recently from ea3b385 to 58032d8 Compare May 14, 2025 16:51
@valeriyvan valeriyvan changed the title Add wokrflow to test on ubuntu-22.04, rename swift-linux.yml -> ubuntu-latest Add wokrflow to test on ubuntu-22.04, rename swift-linux.yml -> ubuntu-24.04 May 14, 2025
@stackotter
Copy link
Owner

stackotter commented May 15, 2025

Given that both workflows are essentially identical, I think it'd be beneficial to instead just parameterise the original workflow using a matrix. Something like so should work:

jobs:
  build-linux:
    strategy:
      matrix:
        os: [ubuntu-22.04, ubuntu-24.04]
    runs-on: ${{ matrix.os }}
    steps:
      ...

Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@stackotter stackotter merged commit 6f369a0 into stackotter:main May 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants