Ensure proper method(s) are supportive of cross-platform swift 6 support #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: furby™ <devs@wabi.foundation>
Signed-off-by: furby™ <devs@wabi.foundation>
Signed-off-by: furby™ <devs@wabi.foundation>
Signed-off-by: furby™ <devs@wabi.foundation>
* Part of our efforts to condense and streamline all the various C/C++ dependencies under one central repository, this is important because Swift makes it all too easy to have 30 different zlib libraries for example, which leads to a headache of duplicated symbols and what not. * That central repository is https://github.com/the-swift-collective Signed-off-by: furby™ <devs@wabi.foundation>
Signed-off-by: furby™ <devs@wabi.foundation>
Signed-off-by: furby™ <devs@wabi.foundation>
Signed-off-by: furby™ <devs@wabi.foundation>
* This ensures scui works with swift 6 strict concurrency - however it is lopsided in that makeCoordinator() is not marked with a main actor. Signed-off-by: furby™ <devs@wabi.foundation>
Signed-off-by: furby™ <devs@wabi.foundation>
* The appropriate method that should NOT have a main actor is determineViewSize, since that will break compiling with swift 6 strict concurrency. Signed-off-by: furby™ <devs@wabi.foundation>
|
For future readers, I've just done the final change manually (this is #105 + one more change). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.