Update golang version in Dockerfile base image #55
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Giddins <segiddins@segiddins.me>
jhrozek
approved these changes
Sep 30, 2024
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
Thanks! With the current main, I saw:
=> ERROR [4/4] RUN go build -o /bin/action ./ 0.5s
------
> [4/4] RUN go build -o /bin/action ./:
0.442 go: go.mod requires go >= 1.22.5 (running go 1.22.1; GOTOOLCHAIN=local)
------
your patch fixes that
jhrozek
added a commit
that referenced
this pull request
Sep 30, 2024
To avoid issues like the one we saw in PR #55, let's add a step to our workflows that builds the docker image, but does not push it.
jhrozek
added a commit
that referenced
this pull request
Sep 30, 2024
To avoid issues like the one we saw in PR #55, let's add a step to our workflows that builds the docker image, but does not push it.
jhrozek
added a commit
that referenced
this pull request
Sep 30, 2024
To avoid issues like the one we saw in PR #55, let's add a step to our workflows that builds the docker image, but does not push it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble getting a build done on the existing base image