feat/redesign-and-improvements #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Moved i18n access to function call time instead of store definition time - Added error handling with a fallback message - Called getInitialMessage() when actually needed in initiateConversation()
There was a problem hiding this comment.
Pull Request Overview
This PR refactors configuration management and improves the document and chat interactions across the frontend and admin applications. Key changes include adding environment-based settings and aliases, enhancing document upload and interaction flows, and updating theming and visual components.
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/tsconfig.base.json | Added new alias entries for shared settings and theme store |
| frontend/tailwind.config.js | Updated theming configuration and color options |
| frontend/libs/shared/ui/ThemeToggle.vue | Introduced a theme toggle component supporting light/dark modes |
| frontend/libs/shared/ui/NavigationContainer.vue | Updated navigation header to use dynamic logo and theme styling |
| frontend/libs/shared/store/theme.store.ts | Added theme persistence and apply functions via Pinia store |
| frontend/libs/shared/settings.ts | Provided environment variable support and fallback defaults |
| Others (chat-app, admin-app, docs, etc.) | Improved document handling, chat messaging, and UI customization |
Comments suppressed due to low confidence (3)
frontend/libs/admin-app/data-access/+state/documents.store.ts:11
- The store id is set to "chat" which could be confusing as this store handles document-related state. Consider renaming the store id to "documents" for clarity and to avoid potential collisions.
export const useDocumentsStore = defineStore("chat", () => {
frontend/libs/shared/ui/NavigationContainer.vue:14
- The property 'themeStore.isDarkMode' is used but not defined in the theme store. Consider replacing it with a computed check such as 'themeStore.currentTheme === "dark"' to ensure proper functionality.
<div :class="`${themeStore.isDarkMode ? 'bg-dark-primary' : 'bg-light-primary'} flex p-4`">
frontend/libs/chat-app/ui/ChatBubble.vue:63
- The v-for loop iterates over 'anchorIds', but this variable is not defined; it should reference 'props.anchorIds'. Updating this will ensure the correct data is used for rendering document jump anchors.
>
a-klos
approved these changes
Jun 20, 2025
| ### UI Customization | ||
| - VITE_BOT_NAME = The AI assistant's display name (default: "Knowledge Agent") | ||
| - VITE_UI_LOGO_PATH = Path to the main navigation logo (default: "/assets/navigation-logo.svg") | ||
| - VITE_UI_THEME_DEFAULT = Default theme when user first visits (default: "light") |
| ui: { | ||
| logoPath: "/assets/navigation-logo.svg", | ||
| theme: { | ||
| default: "light", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces several improvements to the frontend application, focusing on customization options and document handling. The main changes include environment-based configuration, enhanced document interactions, and visual refinements.
Changes
Environment-Based Settings Configuration
.envfiles using the VITE_ prefixDocument Experience Improvements
Visual Updates
How to Test
.envfile with custom settings:Screenshots
tbd