Skip to content

Use tsparticles v3 for fireworks #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use tsparticles v3 for fireworks #2259

wants to merge 1 commit into from

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Jul 4, 2025

Description

With tsparticles v3 and a background mask, I was able to get fireworks show up above images and text inputs while avoiding tsparticles/tsparticles#4870. I tried the background mask in our v2 version but it didn't work as expected.

I let the fireworks preset configure most because I couldn't just copy the config since it now requires the engine as an argument for the color utils. I compared our options with the preset and I believe I applied our customization to the preset.

However, I can still see fireworks going off-screen on small sizes, so I am not sure if 573dd06 worked or just wasn't applied here for some reason.

I need to go now, will check later.

Not sure how long we want to keep the fireworks though?

Video

2025-07-04.17-01-25.mp4

Checklist

Are your changes backward compatible? Please answer below:

yes

For example, a change is not backward compatible if you removed a GraphQL field or dropped a database column.

5. Fireworks are now above images and text inputs but still go off-screen on small sizes though.

For frontend changes: Tested on mobile, light and dark mode? Please answer below:

yes

Did you introduce any new environment variables? If so, call them out explicitly here:

no

@ekzyis ekzyis added the ui/ux label Jul 4, 2025
@ekzyis ekzyis marked this pull request as draft July 4, 2025 15:11
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​tsparticles/​preset-fireworks@​3.2.07610010079100
Added@​tsparticles/​react@​3.0.09910010078100
Added@​tsparticles/​engine@​3.8.1941001008380
Added@​tsparticles/​slim@​3.8.1991001008480

View full report

@huumn
Copy link
Member

huumn commented Jul 4, 2025

I think updating fireworks is fine. We'll only keep it for the weekend at most, but it'll be good to have for new years or next year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants