-
-
Notifications
You must be signed in to change notification settings - Fork 131
Exclude posts in own subs from spam detection #1946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Scroogey-SN
wants to merge
13
commits into
stackernews:master
Choose a base branch
from
Scroogey-SN:issue_787
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6d05682
issue #787: exclude posts in own subs from spam detection
Scroogey-SN af4470a
Merge branch 'master' into pr/1946
ekzyis 8250c2f
Merge branch 'stackernews:master' into issue_787
Scroogey-SN 9bb516f
Merge branch 'stackernews:master' into issue_787
Scroogey-SN 991c6bc
Update prisma/migrations/20250305175301/migration.sql
Scroogey-SN 7eaae87
Merge branch 'stackernews:master' into issue_787
Scroogey-SN 5b6cddf
pass sub to item_spam() to make owner except from escalation
Scroogey-SN cdbd615
remove debug values from sql
Scroogey-SN 55e7a0a
rename migration folder with details
Scroogey-SN 9411bf5
fix lint: space before closing curly brace
Scroogey-SN d5ab608
sub may be undefined, adjust SQL function parameter name
Scroogey-SN 84eac60
Merge branch 'stackernews:master' into issue_787
Scroogey-SN 52d6b92
fix lint: indent
Scroogey-SN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
-- exclude posts in own subs from spam detection | ||
CREATE OR REPLACE FUNCTION item_spam(parent_id INTEGER, user_id INTEGER, within INTERVAL) | ||
RETURNS INTEGER | ||
LANGUAGE plpgsql | ||
AS $$ | ||
DECLARE | ||
repeats INTEGER; | ||
self_replies INTEGER; | ||
BEGIN | ||
-- no fee escalation | ||
IF within = interval '0' THEN | ||
RETURN 0; | ||
END IF; | ||
|
||
SELECT count(*) INTO repeats | ||
FROM "Item" | ||
JOIN "Sub" ON "Sub"."name" = "Item"."subName" | ||
WHERE ( | ||
(parent_id IS NULL AND "parentId" IS NULL) | ||
OR | ||
("parentId" = parent_id AND user_id <> (SELECT i."userId" FROM "Item" i WHERE i.id = "Item"."rootId")) | ||
) | ||
AND "Item"."userId" = user_id | ||
AND "bio" = 'f' | ||
AND "Sub"."userId" <> user_id | ||
AND "Item".created_at > now_utc() - within; | ||
|
||
IF parent_id IS NULL THEN | ||
RETURN repeats; | ||
END IF; | ||
|
||
WITH RECURSIVE base AS ( | ||
SELECT "Item".id, "Item"."parentId", "Item"."userId" | ||
FROM "Item" | ||
WHERE id = parent_id | ||
AND "userId" = user_id | ||
AND created_at > now_utc() - within | ||
AND user_id <> (SELECT i."userId" FROM "Item" i WHERE i.id = "Item"."rootId") | ||
UNION ALL | ||
SELECT "Item".id, "Item"."parentId", "Item"."userId" | ||
FROM base p | ||
JOIN "Item" ON "Item".id = p."parentId" AND "Item"."userId" = p."userId" AND "Item".created_at > now_utc() - within) | ||
SELECT count(*) INTO self_replies FROM base; | ||
|
||
RETURN repeats + self_replies; | ||
END; | ||
$$; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.