-
-
Notifications
You must be signed in to change notification settings - Fork 9
feat!: Implement server role listener #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING: CRD changes .spec.clusterConfig.listenerClass to .spec.servers.roleConfig.listenerClass
Note: This is because it relies on information in the status field
Smoke tests pass at least.
Once merged, I can run all tests in Jenkins and any failures should be fixable through updated hostames. Alternatively, I can run all tests in Replicated locally. Will update here depending on which way I go. Edit: Running all tests sequentially, locally: stackablectl release install dev
make run-dev
scripts/run-tests --parallel 1 --skip-release |
See also related issue when exposing This PR doesn't change the behaviour. This is why there are no tests for external listeners. |
All tests pass stackablectl release install dev
make run-dev
scripts/run-tests --parallel 1 --skip-release
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nitpicks, LGTM overall!
Co-authored-by: Malte Sander <contact@maltesander.com>
Co-authored-by: Malte Sander <contact@maltesander.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #912
Part of stackabletech/issues#692
BREAKING: CRD changes
.spec.clusterConfig.listenerClass
to.spec.servers.roleConfig.listenerClass
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecation
label & add to the deprecation scheduletype/experimental
label & add to the experimental features tracker