Skip to content

Use a ConfigMap for the prepared logs in the logging test #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Jun 27, 2024

Description

Use a ConfigMap for the prepared logs in the logging test

kubectl cp was used to directly copy the prepared logs into the ZooKeeper pod, but this fails if the pod is restarting. This pull request creates a ConfigMap with the prepared logs and mounts it into the log path of the vector container.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@siegfriedweber siegfriedweber requested a review from a team June 27, 2024 09:23
@siegfriedweber siegfriedweber self-assigned this Jun 27, 2024
@siegfriedweber
Copy link
Member Author

siegfriedweber commented Jun 27, 2024

@siegfriedweber siegfriedweber added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 930feaf Jun 28, 2024
32 checks passed
@siegfriedweber siegfriedweber deleted the test/fix-logging-test branch June 28, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants