Skip to content

feat: Add access-control.properties overrides #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 13, 2025
Merged

feat: Add access-control.properties overrides #721

merged 6 commits into from
Mar 13, 2025

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Mar 13, 2025 •
edited by adwk67
Loading

Description

Implementation for #692

--- FAIL: kuttl (1731.56s)
    --- FAIL: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/cluster-operation_trino-latest-470_openshift-false (73.45s)
        --- PASS: kuttl/harness/tls_trino-latest-470_use-authentication-false_use-tls-true_use-internal-tls-true_openshift-false (73.56s)
        --- PASS: kuttl/harness/logging_trino-470_openshift-false (70.66s)
        --- PASS: kuttl/harness/authentication_trino-latest-470_ldap-use-tls-false_openshift-false (265.89s)
        --- PASS: kuttl/harness/logging_trino-455_openshift-false (69.92s)
        --- PASS: kuttl/harness/logging_trino-451_openshift-false (72.95s)
        --- PASS: kuttl/harness/tls_trino-latest-470_use-authentication-true_use-tls-true_use-internal-tls-true_openshift-false (75.16s)
        --- PASS: kuttl/harness/tls_trino-latest-470_use-authentication-true_use-tls-true_use-internal-tls-false_openshift-false (73.80s)
        --- PASS: kuttl/harness/smoke_trino-451_hive-3.1.3_opa-1.0.1_hdfs-3.4.0_zookeeper-3.9.2_openshift-false (507.71s)
        --- PASS: kuttl/harness/tls_trino-latest-470_use-authentication-true_use-tls-false_use-internal-tls-true_openshift-false (74.19s)
        --- PASS: kuttl/harness/tls_trino-latest-470_use-authentication-true_use-tls-false_use-internal-tls-false_openshift-false (68.22s)
        --- PASS: kuttl/harness/resources_trino-latest-470_openshift-false (57.70s)
        --- PASS: kuttl/harness/orphaned-resources_trino-latest-470_openshift-false (44.74s)
        --- PASS: kuttl/harness/authentication_trino-latest-470_ldap-use-tls-true_openshift-false (282.77s)
        --- FAIL: kuttl/harness/opa-authorization_trino-latest-470_hive-latest-4.0.0_opa-1.0.1_keycloak-25.0.0_openshift-false (595.17s)
        --- PASS: kuttl/harness/smoke_trino-455_hive-4.0.0_opa-1.0.1_hdfs-3.4.0_zookeeper-3.9.2_openshift-false (362.55s)
        --- PASS: kuttl/harness/smoke_trino-470_hive-3.1.3_opa-1.0.1_hdfs-3.4.0_zookeeper-3.9.2_openshift-false (394.00s)
        --- PASS: kuttl/harness/smoke_trino-455_hive-3.1.3_opa-1.0.1_hdfs-3.4.0_zookeeper-3.9.2_openshift-false (401.31s)
        --- PASS: kuttl/harness/tls_trino-latest-470_use-authentication-false_use-tls-false_use-internal-tls-true_openshift-false (71.47s)
        --- PASS: kuttl/harness/tls_trino-latest-470_use-authentication-false_use-tls-true_use-internal-tls-false_openshift-false (72.76s)
        --- PASS: kuttl/harness/smoke_trino-451_hive-4.0.0_opa-1.0.1_hdfs-3.4.0_zookeeper-3.9.2_openshift-false (383.24s)
        --- PASS: kuttl/harness/tls_trino-latest-470_use-authentication-false_use-tls-false_use-internal-tls-false_openshift-false (69.02s)
        --- PASS: kuttl/harness/smoke_trino-470_hive-4.0.0_opa-1.0.1_hdfs-3.4.0_zookeeper-3.9.2_openshift-false (407.38s)
FAIL
ERROR:root:kuttl failed

TODO: Failing integration test needs to run again after fix #720

--- PASS: kuttl (284.31s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/opa-authorization_trino-latest-470_hive-latest-4.0.0_opa-1.0.1_keycloak-25.0.0_openshift-false (284.30s)
PASS

Definition of Done Checklist

# Author
- [x] Changes are OpenShift compatible
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible

# Reviewer
- [x] Code contains useful comments
- [ ] Code contains useful logging statements
- [x] (Integration-)Test cases added
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@xeniape xeniape self-assigned this Mar 13, 2025
@xeniape xeniape linked an issue Mar 13, 2025 that may be closed by this pull request
Allow overrides for access-control.properties #692
Closed
@xeniape xeniape marked this pull request as ready for review March 13, 2025 09:28
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Mar 13, 2025
@xeniape xeniape requested a review from a team March 13, 2025 10:16
@adwk67 adwk67 requested review from adwk67 and removed request for a team March 13, 2025 11:22
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 13, 2025
adwk67
adwk67 previously approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for the unit test!

Openshift:

--- PASS: kuttl (1024.44s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/orphaned-resources_trino-latest-470_openshift-true (52.67s)
        --- PASS: kuttl/harness/tls_trino-latest-470_use-authentication-false_use-tls-true_use-internal-tls-true_openshift-true (67.28s)
        --- PASS: kuttl/harness/cluster-operation_trino-latest-470_openshift-true (86.45s)
        --- PASS: kuttl/harness/logging_trino-470_openshift-true (81.75s)
        --- PASS: kuttl/harness/resources_trino-latest-470_openshift-true (334.16s)
        --- PASS: kuttl/harness/opa-authorization_trino-latest-470_hive-latest-4.0.1_opa-1.0.1_keycloak-25.0.0_openshift-true (366.75s)
        --- PASS: kuttl/harness/authentication_trino-latest-470_ldap-use-tls-true_openshift-true (315.13s)
        --- PASS: kuttl/harness/smoke_trino-470_hive-4.0.1_opa-1.0.1_hdfs-3.4.0_zookeeper-3.9.3_openshift-true (498.85s)
PASS

@xeniape xeniape added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit a6e644a Mar 13, 2025
16 of 17 checks passed
@xeniape xeniape deleted the feat/add-access-control-properties-overrides branch March 13, 2025 14:04
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Mar 14, 2025
@lfrancke
Copy link
Member

  • Please add a link to the docs if this issue/PR has any
  • If this is worth a mention in the release notes please add a text snippet to use and the release-note or release-note/action-required
  • If this is a bug worth mentioning in the release notes please use the form "Previously, this went wrong. With this release, this was fixed in the following way." for the release notes

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Mar 26, 2025
@xeniape
Copy link
Member Author

xeniape commented Apr 1, 2025

This PR belongs to this issue #692. @maltesander mentions the docs and release note there.

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@xeniape xeniape

Labels
release/25.3.0
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow overrides for access-control.properties
3 participants
@xeniape @lfrancke @adwk67