Skip to content

feat: Support configuring JVM arguments #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 28, 2025
Merged

feat: Support configuring JVM arguments #677

merged 16 commits into from
Jan 28, 2025

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Dec 3, 2024

Description

Part of stackabletech/issues#584
Part of stackabletech/operator-rs#942

# Tasks
- [x] Make sure to update RBAC roles to patch events!
- [x] Changelog
- [x] `cargo +nightly update -Z unstable-options --breaking --dry-run`
- [x] `make regenerate-charts`
- [x] `make regenerate-nix`

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [ ] Code contains useful logging statements
- [x] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [x] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@sbernauer sbernauer changed the title feat: Support experimental additional JCM arguments feat: Support experimental additional JVM arguments Dec 3, 2024
@sbernauer sbernauer changed the title feat: Support experimental additional JVM arguments feat: Support additional JVM arguments Dec 27, 2024
@sbernauer sbernauer changed the title feat: Support additional JVM arguments feat: Support configuring JVM arguments Dec 27, 2024
@sbernauer sbernauer marked this pull request as ready for review January 15, 2025 08:36
@sbernauer sbernauer requested a review from maltesander January 15, 2025 08:36
@sbernauer sbernauer requested a review from maltesander January 16, 2025 10:34
maltesander
maltesander previously approved these changes Jan 16, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

maltesander
maltesander previously approved these changes Jan 24, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer
Copy link
Member Author

@sbernauer
Copy link
Member Author

Tests passed 🥳

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 80a82f7 Jan 28, 2025
17 checks passed
@sbernauer sbernauer deleted the feat/jvm-arguments branch January 28, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants