-
-
Notifications
You must be signed in to change notification settings - Fork 6
TrustStore CRD #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrustStore CRD #557
Conversation
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Drop ring dependency and update RustCrypto
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
update crypto dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following questions are open:
- Allow customers to request CA cert (e.g. for external clients) #410 (comment)
- https://github.com/stackabletech/decisions/issues/42#issuecomment-2754317110
I did not review the complete p12 directory, but only the changes to v0.6.3.
This is currently only used by the TrustStore controller, but would also be a step towards exposing the same info for the CSI endpoints in the future.
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
…ret-operator into feature/truststore-crd
Ah didn't see #410 (comment) - replying to that in there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not super happy mixing licenses in a single repo (I do understand that we already implicitly do by having dependencies to otherwise licensed items but tooling wise that is different). I'm unsure. @soenkeliebau Opinions? |
I'm inclined to vote with "perfect is the enemy of done" here and leave it as is.. One other idea I had was to use something like https://github.com/itmettkeDE/cargo-patch but that'll probably play havoc with SBOMs etc.. As I said, I struggle to have a strong opinion. |
Description
Fixes #410.
rust/p12
is imported from hjiayz/p12@9983420 (fff63d1), can't really do much about CLA failures from before that point (and beyond that I've kept the changes fairly minimal to enable our use case). Discussed at https://stackable-workspace.slack.com/archives/C033A863YPL/p1741869321744189.Definition of Done Checklist