-
-
Notifications
You must be signed in to change notification settings - Fork 7
Upstream Hostname into operator-rs #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh, that's not automatic? Gotcha. |
Openshift is green once running the correct suite.. :P |
FYI, I put this issue on the board so that everyone has a chance to follow development :) |
|
||
- Refactored hostname validation ([#494]). | ||
- BREAKING: Hostname validation is now somewhat stricter. | ||
- BREAKING: Hostname validation is now enforced in CRD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we had some discussions around RFC 1123 and renamed it accordingly to the RFC (at least we hope ^^), before it gaines widespread adoption. We would have involved you but you where on vacation and we did not want to further delay the PR, but please feel free to veto, happy to discuss with @Techassi!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
It's becoming useful in other operators, so let's try to share it.
As a bonus, by reusing the validation machinery in op-rs we can also add the validation rules to the CRD.
Op-rs equivalent: stackabletech/operator-rs#851
Definition of Done Checklist