Skip to content

feat(run-tests): Handle existing namespaces and permission errors #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

lfrancke
Copy link
Member

Handle existing namespaces and permission errors more gracefully

This does change behavior.
In the past run-tests would fail if we can't create the namespace but now we'll proceed because it might already exist and we just can't check easily.

@lfrancke lfrancke force-pushed the feat/run-tests-namespace branch 4 times, most recently from 9b70e27 to 37dbfb5 Compare June 11, 2025 08:52
…e gracefully

This _does_ change behavior.
In the past run-tests would fail if we can't create the namespace but
now we'll proceed because it might already exist and we just can't check
easily.
@lfrancke lfrancke force-pushed the feat/run-tests-namespace branch from 37dbfb5 to be0e1aa Compare June 11, 2025 08:56
@lfrancke lfrancke marked this pull request as ready for review June 11, 2025 09:01
@lfrancke lfrancke self-assigned this Jun 11, 2025
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Jun 11, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. I have needed this.

Too bad that Helm usually kills the fun (when charts already exist).

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 11, 2025
@lfrancke lfrancke added this pull request to the merge queue Jun 11, 2025
@lfrancke lfrancke moved this from Development: In Review to Development: Done in Stackable Engineering Jun 11, 2025
Merged via the queue into main with commit 0fd18fc Jun 11, 2025
2 checks passed
@lfrancke lfrancke deleted the feat/run-tests-namespace branch June 11, 2025 16:02
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants