Skip to content

fix: Lower Logback checkIncrement value #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Conversation

labrenbe
Copy link
Member

@labrenbe labrenbe commented Sep 3, 2024

Description

Partially fixes stackabletech/issues#574.

By default Logback checks the size of log files every 60s to determine if log rotation should be triggered. This can be too slow in NiFi with high load resulting in log files becoming larger than the provisioned emptyDir volume. Lowering the checkIncrement property allows for more timely file size checks.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [x] Changelog updated
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@labrenbe labrenbe self-assigned this Sep 3, 2024
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change must be added to the changelog.

Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@labrenbe labrenbe added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 17054c3 Sep 12, 2024
10 checks passed
@labrenbe labrenbe deleted the fix/logback-check-increment branch September 12, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve experience for users of the log aggregation feature
2 participants