Skip to content

Fix the processing of corrupted log events #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Jun 4, 2024

Description

Fix the processing of corrupted log events

Fixes stackabletech/issues#491

Integration tests

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@siegfriedweber siegfriedweber marked this pull request as ready for review June 7, 2024 10:35
@siegfriedweber siegfriedweber requested a review from a team June 7, 2024 10:35
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sadly have no input on the actual change in the Rust code, because this is not really my topic. But there is a small required change in the changelog.

I suggest other people should chime in here @stackabletech/developers.

@siegfriedweber siegfriedweber requested a review from a team June 10, 2024 09:23
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no vector expert, but this change seems to make sense :)

@siegfriedweber siegfriedweber requested a review from Techassi June 12, 2024 09:06
@siegfriedweber siegfriedweber added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit 998a169 Jun 12, 2024
17 checks passed
@siegfriedweber siegfriedweber deleted the fix/vector-log-processing branch June 12, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix invalid log events
3 participants