Skip to content

fix: allow uppercase characters in domain names #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Jun 23, 2025

Description

Implementation of #1022

According to RFC 1123 (which references RFC 952):

No distinction is made between upper and lower case.

This PR:

  • Adjusts domain name regex and tests
  • Moves code only used in tests into test module
  • Removes name_is_dns_subdomain due to not being used in any other project

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@xeniape xeniape self-assigned this Jun 23, 2025
@xeniape xeniape linked an issue Jun 23, 2025 that may be closed by this pull request
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Jun 23, 2025
NickLarsenNZ
NickLarsenNZ previously approved these changes Jun 23, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 23, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeniape xeniape added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit b2bf0e8 Jun 25, 2025
8 checks passed
@xeniape xeniape deleted the fix/uppercase-chars-in-domain-names branch June 25, 2025 07:18
@xeniape xeniape moved this from Development: In Review to Development: Done in Stackable Engineering Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

Upper-case characters not allowed in domain names
2 participants