-
-
Notifications
You must be signed in to change notification settings - Fork 4
fix: expand AD user name filter #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Depends on stackabletech/krb5-rs#1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality-wise this seems to work fine for me. Do we want to add cases for this to the ad-user-info
test?
Indeed. Successfully tested with the help of stackabletech/ad-init#8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if tests pass
❯ ./scripts/run-tests --skip-release --skip-delete --test ad-user-info
...
--- PASS: kuttl (17.51s)
--- PASS: kuttl/harness (0.00s)
--- PASS: kuttl/harness/ad-user-info_opa-latest-1.4.2_openshift-false (17.21s)
PASS |
Description
Fixes #702
How I tested
ad-test
, a new AD user calledrazvan
in theSBLE.TEST
realm and addedrazvan
to thead-test
group.opa-operator
withmake run-dev
OPA cluster definition:
The (debug) logs of the user-info-fetcher container showed:
where the LDAP search filter was:
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecation
label & add to the deprecation scheduletype/experimental
label & add to the experimental features tracker