Skip to content

tests: added namespace patch for openshift tests #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Apr 12, 2024

Description

Part of stackabletech/issues#566.

OKD:

--- PASS: kuttl (141.07s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-true (133.13s)

Azure:

--- PASS: kuttl (65.98s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-false (64.26s)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@adwk67 adwk67 enabled auto-merge April 12, 2024 08:01
@adwk67 adwk67 added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit 165840a Apr 12, 2024
30 checks passed
@adwk67 adwk67 deleted the test/add-openshift-permission branch April 12, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants