Skip to content

Updating version in upgrade test #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

Maleware
Copy link
Member

Description

Changes stackable0.0.0-dev to stackable24.7.0 in upgrade-zookeeper

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@NickLarsenNZ
Copy link
Member

This might be something that needs to be caught in: https://github.com/stackabletech/stackable-utils/blob/main/release/create-release-tag.sh

@maltesander
Copy link
Member

Yeah and there are more left overs

image: docker.stackable.tech/stackable/testing-tools:0.2.0-stackable0.0.0-dev
(and more)

@maltesander maltesander self-requested a review July 30, 2024 12:31
@adwk67
Copy link
Member

adwk67 commented Aug 26, 2024

This PR was necessary as it checks a label (which causes the test to fail if not updated to the release version).

@sbernauer sbernauer requested a review from adwk67 September 2, 2024 07:09
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfrancke lfrancke merged commit 6f1fbcf into release-24.7 Sep 10, 2024
29 of 31 checks passed
@lfrancke lfrancke deleted the fix/kafka-integration-tests branch September 10, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants