Skip to content

fix: Bump default memory reservation to 768Mi #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ All notable changes to this project will be documented in this file.
### Changed

- Default to OCI for image metadata and product image selection ([#561]).
- Increase default memory reservation to `768Mi` to avoid `OOMKilled` ([#578]).

### Fixed

Expand All @@ -29,6 +30,7 @@ All notable changes to this project will be documented in this file.
[#561]: https://github.com/stackabletech/hive-operator/pull/561
[#572]: https://github.com/stackabletech/hive-operator/pull/572
[#574]: https://github.com/stackabletech/hive-operator/pull/574
[#578]: https://github.com/stackabletech/hive-operator/pull/578

## [24.11.1] - 2025-01-10

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/hive/pages/usage-guide/resources.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ A minimal HA setup consisting of 2 Hive metastore instances has the following ht

* `100m` CPU request
* `3000m` CPU limit
* `1280m` memory request and limit
* `1792Mi` memory request and limit

Of course, additional services, require additional resources. For Stackable components, see the corresponding documentation on further resource requirements.

Expand All @@ -22,10 +22,10 @@ metastore:
resources:
requests:
cpu: "250m"
memory: "512Mi"
memory: "768Mi"
limits:
cpu: "1000m"
memory: "512Mi"
memory: "768Mi"
----

The operator may configure an additional container for log aggregation. This is done when log aggregation is configured as described in xref:concepts:logging.adoc[]. The resources for this container cannot be configured using the mechanism described above. Use xref:home:concepts:overrides.adoc#_pod_overrides[podOverrides] for this purpose.
Expand Down
2 changes: 1 addition & 1 deletion rust/operator-binary/src/config/jvm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ mod tests {
-Djavax.net.ssl.trustStorePassword=changeit \
-Djavax.net.ssl.trustStoreType=pkcs12"
);
assert_eq!(hadoop_heapsize_env, "409");
assert_eq!(hadoop_heapsize_env, "614");
}

#[test]
Expand Down
2 changes: 1 addition & 1 deletion rust/operator-binary/src/crd/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ impl MetaStoreConfig {
max: Some(Quantity("1000m".to_owned())),
},
memory: MemoryLimitsFragment {
limit: Some(Quantity("512Mi".to_owned())),
limit: Some(Quantity("768Mi".to_owned())),
runtime_limits: NoRuntimeLimitsFragment {},
},
storage: MetastoreStorageConfigFragment {
Expand Down
4 changes: 2 additions & 2 deletions tests/templates/kuttl/kerberos-hdfs/60-assert.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ spec:
resources:
limits:
cpu: "1"
memory: 512Mi
memory: 768Mi
requests:
cpu: 250m
memory: 512Mi
memory: 768Mi
{% if lookup('env', 'VECTOR_AGGREGATOR') %}
- name: vector
{% endif %}
Expand Down
4 changes: 2 additions & 2 deletions tests/templates/kuttl/kerberos-s3/60-assert.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ spec:
resources:
limits:
cpu: "1"
memory: 512Mi
memory: 768Mi
requests:
cpu: 250m
memory: 512Mi
memory: 768Mi
{% if lookup('env', 'VECTOR_AGGREGATOR') %}
- name: vector
{% endif %}
Expand Down
4 changes: 2 additions & 2 deletions tests/templates/kuttl/smoke/60-assert.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ spec:
resources:
limits:
cpu: "1"
memory: 512Mi
memory: 768Mi
requests:
cpu: 250m
memory: 512Mi
memory: 768Mi
{% if lookup('env', 'VECTOR_AGGREGATOR') %}
- name: vector
{% endif %}
Expand Down