Skip to content

chore: Version CRD and HiveClusterConfig #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 12, 2025
Merged

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Feb 5, 2025

Part of stackabletech/issues#642

This PR adds versioning to the Hive CRD and cluster config. It doesn't introduce any new version or updates the CRD in any way. It currently emits the same crd.yaml which is the correct expected behaviour.

Tip

It is recommended to look at this PR on a commit-by-commit basis to better understand the individual steps taken. Also take a look at the macro documentation.

@Techassi Techassi self-assigned this Feb 5, 2025
@Techassi Techassi changed the title chore: Version CRD chore: Version CRD and HiveClusterConfig Feb 6, 2025
@Techassi Techassi marked this pull request as ready for review February 6, 2025 15:21
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 8a9c5b9 Feb 12, 2025
17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the chore/add-crd-versioning branch February 12, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants