Skip to content

fix(test): smoke testing env and config overrides #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Conversation

razvan
Copy link
Member

@razvan razvan commented Aug 22, 2024

Description

Part of: stackabletech/issues#548

🟢 Test

$ ./scripts/run-tests --test-suite smoke-latest --skip-release
...
--- PASS: kuttl (209.68s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_postgres-12.5.6_hive-3.1.3_openshift-false_s3-use-tls-false (208.28s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@razvan razvan requested a review from a team August 22, 2024 09:59
@xeniape xeniape self-requested a review August 23, 2024 11:01
Copy link
Member

@xeniape xeniape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions:

@razvan razvan requested a review from xeniape August 26, 2024 09:40
@razvan razvan enabled auto-merge August 26, 2024 15:59
@razvan razvan closed this Aug 26, 2024
auto-merge was automatically disabled August 26, 2024 16:07

Pull request was closed

@razvan razvan reopened this Aug 26, 2024
@razvan razvan enabled auto-merge August 26, 2024 16:08
@razvan razvan added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 26ef5a6 Aug 26, 2024
54 checks passed
@razvan razvan deleted the fix/env-overrides branch August 26, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants