Skip to content

Add cipher suite (AES/CTR/NoPadding) per default #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2025

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Jun 11, 2025

Description

fixes #680

The hdfs-operator now defaults to AES/CTR/NoPadding for dfs.encrypt.data.transfer.cipher.suite to improve security and performance

hdfs-site.xml:

<property>
  <name>dfs.data.transfer.protection</name>
  <value>privacy</value>
</property>
<property>
  <name>dfs.encrypt.data.transfer</name>
  <value>true</value>
</property>                                                                                  
<property>
  <name>dfs.encrypt.data.transfer.cipher.suite</name>
  <value>AES/CTR/NoPadding</value>                                                                                   
</property>

Test:

--- PASS: kuttl (608.24s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/kerberos_hadoop-3.4.1_zookeeper-latest-3.9.3_krb5-1.21.1_opa-1.4.2_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_openshift-false (608.23s)

@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering Jun 11, 2025
NickLarsenNZ
NickLarsenNZ previously approved these changes Jun 11, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Does this need a release-note? If so, it will also need the scheduled-for and release-note label.

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 11, 2025
@maltesander
Copy link
Member Author

LGTM

Does this need a release-note? If so, it will also need the scheduled-for and release-note label.

Not sure, would let @lfrancke decide.

@lfrancke
Copy link
Member

To answer the question: I think it's worth a release note entry

@NickLarsenNZ NickLarsenNZ added scheduled-for/25.7.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 12, 2025
@maltesander
Copy link
Member Author

Release note:

The HDFS operator now defaults `dfs.encrypt.data.transfer.cipher.suite` to `AES/CTR/NoPadding` to improve security and performance.

@maltesander maltesander requested a review from lfrancke June 12, 2025 07:13
NickLarsenNZ
NickLarsenNZ previously approved these changes Jun 12, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander changed the title Add cipher suite (AES/CTR/NoPadding) and key size (128) per default Add cipher suite (AES/CTR/NoPadding) per default Jun 12, 2025
@maltesander maltesander enabled auto-merge June 12, 2025 07:24
@maltesander maltesander added this pull request to the merge queue Jun 12, 2025
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Jun 12, 2025
Merged via the queue into main with commit ec416eb Jun 12, 2025
17 checks passed
@maltesander maltesander deleted the fix/set-cipher-suite-and-key-length-default branch June 12, 2025 07:39
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/25.7.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
Development

Successfully merging this pull request may close these issues.

Use AES by default for HDFS wire encryption
4 participants