Skip to content

Update test and doc versions #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 13, 2025
Merged

Update test and doc versions #656

merged 7 commits into from
Mar 13, 2025

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Mar 12, 2025

Description

  • Add: 3.4.1
  • Mark 3.4.0 as deprecated

Part of stackabletech/docker-images#1018

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [x] (Integration-)Test cases ~added~ : dimensions updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@maltesander maltesander self-assigned this Mar 12, 2025
@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering Mar 12, 2025
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 12, 2025
@adwk67 adwk67 self-requested a review March 12, 2025 13:53
@Techassi
Copy link
Member

Also, I would avoid the fixes keyword in the PR description, because that will auto-close the tracking issue. And there are most likely open tasks which are not done yet.

I will edit the description accordingly.

@maltesander maltesander requested review from adwk67 and Techassi March 12, 2025 14:31
Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com>
adwk67
adwk67 previously approved these changes Mar 12, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! - LGTM

@maltesander maltesander requested a review from Techassi March 13, 2025 10:52
@maltesander maltesander added this pull request to the merge queue Mar 13, 2025
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Mar 13, 2025
Merged via the queue into main with commit ed49575 Mar 13, 2025
16 of 17 checks passed
@maltesander maltesander deleted the update-supported-versions branch March 13, 2025 11:37
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants