Skip to content

Make uid/gid configurable & change group of files - part 3 #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Oct 23, 2024
Merged

Make uid/gid configurable & change group of files - part 3 #897

merged 23 commits into from
Oct 23, 2024

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Oct 16, 2024 •
edited
Loading

Description

This is a follow-up for #849 and #890 and includes:

Integration tests ran locally successfully when the ✔️ is added

@lfrancke
Make uid/gid configurable & change group of files
e7e3283 
This is a follow-up for #849 and includes:

- The missing bits for Hive
- Kafka
@lfrancke
More tools now migrated but not tested yet:
e6606ef 
- Kafka Testing Tools
- KCat
- NiFi
- Omid
@lfrancke
- OPA
6d4f536 
- Spark (WIP)
@lfrancke
Adds Spark and a changelog entry
8ad5fa4
@lfrancke
- statsd_exporter
502b864 
- superset
@lfrancke
Merge branch 'main' into feat/user-handling-pt3
83310eb 
# Conflicts:
#	CHANGELOG.md
#	hive/Dockerfile
#	kafka/Dockerfile
#	nifi/Dockerfile
#	omid/Dockerfile
#	opa/Dockerfile
#	spark-k8s/Dockerfile
@lfrancke
- superset
6155a94 
- tools
@lfrancke lfrancke mentioned this pull request Oct 16, 2024
Open
6 tasks
@lfrancke lfrancke self-assigned this Oct 16, 2024
@lfrancke lfrancke marked this pull request as ready for review October 17, 2024 08:41
@lfrancke lfrancke requested a review from NickLarsenNZ October 17, 2024 08:44
@lfrancke lfrancke mentioned this pull request Oct 17, 2024
Open
26 tasks
NickLarsenNZ
NickLarsenNZ previously approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Left comments about things that should be picked up by hadolint (shellcheck), but then stopped. I can comment on the rest if you want, or we can leave those changes for another time.

@lfrancke @NickLarsenNZ
Update tools/Dockerfile
652fb5c 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
lfrancke and others added 7 commits October 23, 2024 09:57
@lfrancke @NickLarsenNZ
Update superset/Dockerfile
ceabe97 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@lfrancke @NickLarsenNZ
Update tools/Dockerfile
04c9942 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@lfrancke @NickLarsenNZ
Update trino-cli/Dockerfile
6c1bdd1 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@lfrancke @NickLarsenNZ
Update trino-cli/Dockerfile
7f16dad 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@lfrancke @NickLarsenNZ
Update superset/Dockerfile
b9aca36 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@lfrancke
Merge branch 'main' into feat/user-handling-pt3
cb1cae6 
# Conflicts:
#	CHANGELOG.md
@lfrancke
Merge remote-tracking branch 'origin/feat/user-handling-pt3' into fea…
85ad019 
…t/user-handling-pt3
@lfrancke lfrancke requested a review from NickLarsenNZ October 23, 2024 08:01
@lfrancke lfrancke enabled auto-merge October 23, 2024 08:10
NickLarsenNZ
NickLarsenNZ approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfrancke lfrancke added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 1e5f085 Oct 23, 2024
2 checks passed
@lfrancke lfrancke deleted the feat/user-handling-pt3 branch October 23, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@lfrancke lfrancke

Labels
release/24.11.0
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfrancke @NickLarsenNZ