-
-
Notifications
You must be signed in to change notification settings - Fork 7
chore(nifi): Bump to 1.28.1, upgrade postgres jdbc driver #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the bump! Can you please make sure the demos are still working? I recall having problems bumping to 2.0.0 in the last release cycle
We have a separate task to test demos, but I can do a quick test now before merging. I believe it is still the case that upgrading from 1.x.x to 2.x.x is breaking (as indicated by the major version), but there don't appear to breaking changes from 2.0.x to 2.2.x judging by the release notes: https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version2.2.0) |
It looks like there are some big changes. At least, the signal-processing demo doesn't work as it depends on nipy which doesn't fully support NiFi 2. See: Chaffelson/nipyapi#380. So, We could just make the demo use 1.28.1. What do you think @sbernauer? |
Yes, seems like I recalled correctly :/ I would leave the decision to you. |
It has been decided that 2.x will remain experimental until we can support flow/template uploads via NiFi Registry. I will therefore bump these demos to NiFi 1.28.1, and if we're lucky, convert the Flow to JSON within the repo. |
…e to NiFi 2.x problems
…8.1 due to NiFi 2.x problems
9d80ed6
to
117fd66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if demos still work.
Very nice addition with the init containers, thank you!
Part of stackabletech/docker-images#966.
Important
Despite the branch name, we are not bumping the demos to 2.2.0 as they rely on uploading templates.
Testing