Skip to content

chore(nifi): Bump to 1.28.1, upgrade postgres jdbc driver #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 11, 2025

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Feb 20, 2025

Part of stackabletech/docker-images#966.

  • Update NiFi demos and custom image to 1.28.1
  • Update the postgres jar and move it to a more appropriate image repository (it is not related to timescale).
  • Update the docs to explain which dashboard is being described.
  • Improve readability of the initialisation jobs.

Important

Despite the branch name, we are not bumping the demos to 2.2.0 as they rely on uploading templates.

Testing

  • signal-processing
  • nifi-kafka-druid-earthquake-data
  • nifi-kafka-druid-water-level-data

sbernauer
sbernauer previously approved these changes Feb 20, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bump! Can you please make sure the demos are still working? I recall having problems bumping to 2.0.0 in the last release cycle

@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Feb 20, 2025

Thanks for the bump! Can you please make sure the demos are still working? I recall having problems bumping to 2.0.0 in the last release cycle

We have a separate task to test demos, but I can do a quick test now before merging.

I believe it is still the case that upgrading from 1.x.x to 2.x.x is breaking (as indicated by the major version), but there don't appear to breaking changes from 2.0.x to 2.2.x judging by the release notes: https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version2.2.0)

@NickLarsenNZ
Copy link
Member Author

It looks like there are some big changes.

At least, the signal-processing demo doesn't work as it depends on nipy which doesn't fully support NiFi 2. See: Chaffelson/nipyapi#380.

So, We could just make the demo use 1.28.1. What do you think @sbernauer?

@sbernauer
Copy link
Member

Yes, seems like I recalled correctly :/

I would leave the decision to you.
My only 2 cents is that we need to do the bump eventually and I we should not accumulate to much technical debt ;)

@NickLarsenNZ NickLarsenNZ changed the title chore(nifi): Bump to 2.2.0, upgrade postgres jdbc driver chore(nifi): Bump to 1.28.1, upgrade postgres jdbc driver Feb 24, 2025
@NickLarsenNZ
Copy link
Member Author

Yes, seems like I recalled correctly :/

I would leave the decision to you. My only 2 cents is that we need to do the bump eventually and I we should not accumulate to much technical debt ;)

It has been decided that 2.x will remain experimental until we can support flow/template uploads via NiFi Registry.

I will therefore bump these demos to NiFi 1.28.1, and if we're lucky, convert the Flow to JSON within the repo.

@NickLarsenNZ NickLarsenNZ moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Feb 27, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if demos still work.
Very nice addition with the init containers, thank you!

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Feb 28, 2025
@NickLarsenNZ NickLarsenNZ enabled auto-merge March 11, 2025 10:41
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit d7eeeba Mar 11, 2025
2 checks passed
@NickLarsenNZ NickLarsenNZ deleted the bump/nifi-2.2.0 branch March 11, 2025 10:42
@NickLarsenNZ NickLarsenNZ moved this from Development: In Review to Development: Done in Stackable Engineering Mar 11, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants