Skip to content

fix: E2E Security demo - Separate DB setup from superset resource #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Feb 17, 2025

The postgresl dump file contains the dashboard assets, created under an earlier version of superset (3.x). Since the upgrade to 4.x there appears to be changes made (by flask?) to the database that overwrite the restore action. This PR move the DB initialization to a separate step. It now looks like this:

  • postgres installed via helm
  • once the postgres statefulset is ready, a job runs that downloads the dump file and restores it
  • superset waits for this job to complete but does not restore anything (although there will a DB migration due to the version differences)

Logged in via Keycloak:

image

@adwk67 adwk67 marked this pull request as ready for review February 17, 2025 11:10
@adwk67 adwk67 self-assigned this Feb 17, 2025
@adwk67 adwk67 requested a review from a team February 17, 2025 11:10
@adwk67 adwk67 changed the title fix: Separate DB setup from superset resource fix: E2E Security demo - Separate DB setup from superset resource Feb 17, 2025
@NickLarsenNZ NickLarsenNZ requested review from NickLarsenNZ and removed request for a team February 17, 2025 11:28
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @adwk67

@adwk67 adwk67 added this pull request to the merge queue Feb 17, 2025
Merged via the queue into main with commit dbfb6dc Feb 17, 2025
2 checks passed
@adwk67 adwk67 deleted the fix/e2e-setup-postgres branch February 17, 2025 11:30
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants