Skip to content

fix: Increase test-cluster TTL to 6h #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix: Increase test-cluster TTL to 6h #123

merged 1 commit into from
Nov 12, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 12, 2024

As HDFS tests can take longer than 4 hours, currently this deletes the k8s before the test finished, resulting in
Get "https://cluster-dns-1nvkkrsm.hcp.eastus.azmk8s.io:443/apis/apps/v1/namespaces/kuttl-test-fond-chipmunk/statefulsets/test-hdfs-automatic-log-namenode-default": dial tcp: lookup cluster-dns-1nvkkrsm.hcp.eastus.azmk8s.io on 8.8.8.8:53: no such host.

Discussed in https://github.com/replicated-collab/stackable-replicated/issues/7

@sbernauer sbernauer self-assigned this Nov 12, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer merged commit f15f036 into main Nov 12, 2024
1 check passed
@sbernauer sbernauer deleted the fix/cluster-ttl branch November 12, 2024 08:03
@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Nov 12, 2024

@Techassi, FYI for the new integration tests.
I'm guessing we can either set the default higher, or override it per case in the infrastructure.yaml (pending stackabletech/hdfs-operator#601).

I am thinking the infrastructure.yaml since only one operator needs it longer for now.
Saves a whole release of the action just to set a default.

What do you suggest?

@Techassi
Copy link
Member

Techassi commented Nov 12, 2024

I think we should keep the default as low as possible (where most operators still succeed). If individual operators need longer TTLs, we can set it in the integration test config file.

NickLarsenNZ added a commit to stackabletech/hdfs-operator that referenced this pull request Nov 12, 2024
@NickLarsenNZ
Copy link
Member

Done in stackabletech/hdfs-operator@b7a16d4 (stackabletech/hdfs-operator#601)

@sbernauer
Copy link
Member Author

Sounds good! Was thinking of something similar :)

github-merge-queue bot pushed a commit to stackabletech/hdfs-operator that referenced this pull request Dec 13, 2024
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@52c2678

Reference-to: stackabletech/operator-templating@52c2678 (Add integration test workflow)

* chore: Add integration test config file

* chore(ci): Set test parameters for scheduled runs

* chore(test): bump the cluster-ttl as per stackabletech/ci#123

* bump action version

* update infrastructure

* drop the nodes

* another infrastructure tweak

---------

Co-authored-by: Techassi <sascha.lautenschlaeger@stackable.tech>
Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants