Skip to content

feat: publish with the pypa action #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2024
Merged

feat: publish with the pypa action #33

merged 3 commits into from
Dec 5, 2024

Conversation

razvan
Copy link
Member

@razvan razvan commented Nov 26, 2024 •
edited
Loading

Needed for attestation support.

Followed instructions from here minus package signing.

@razvan razvan changed the title feat: pubish with the pypa action feat: publish with the pypa action Nov 26, 2024
@razvan razvan requested a review from Techassi November 26, 2024 16:14
@razvan razvan self-assigned this Nov 26, 2024
@razvan razvan requested a review from lfrancke November 26, 2024 16:14
Techassi
Techassi reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two comments.

Also, while at it, we should bump the action versions. I think there are a bunch with more recent versions.

@razvan razvan requested a review from Techassi December 4, 2024 16:20
@razvan razvan added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit e1bb738 Dec 5, 2024
7 checks passed
@razvan razvan deleted the feat/publish-with-pypa branch December 5, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

@lfrancke lfrancke Awaiting requested review from lfrancke

Assignees

@razvan razvan

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razvan @Techassi